Newer and better RSRS#5
Merged
Merged
Conversation
The fixed-rank estimators capped carried coarser boxes by the requested rank before those boxes were processed. On adaptive meshes this undercounted the runtime near-field sketch size, so per-level and constant modes could start with too few samples and only discover the larger requirement at a later level, leading to late sample growth and LAPACK/subview failures. Estimate the runtime active-sample upper bound with carried boxes at full size, use it directly for per-level budgets, and floor constant budgets by it. Keep runtime targets from falling below level minima and add a regression test for carried-box capping.
…actorized LU only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeat of #3 (but don't want to squash merge this time)