fix: replace xlsx with exceljs to resolve Dependabot CVEs#94
Merged
benbernard merged 2 commits intomasterfrom Feb 24, 2026
Merged
fix: replace xlsx with exceljs to resolve Dependabot CVEs#94benbernard merged 2 commits intomasterfrom
benbernard merged 2 commits intomasterfrom
Conversation
Replace the abandoned SheetJS xlsx npm package (stuck at 0.18.5 with no patched version) with exceljs to fix CVE-2023-30533 (Prototype Pollution) and CVE-2024-22363 (ReDoS), both high severity. Rewrite fromxls.ts to use the exceljs async API, override finish() as async, and add await to op.finish() calls in the dispatcher and executor (backward compatible since await on void is a no-op). Add comprehensive tests for fromxls covering headers, sheet selection, and number parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Performance Benchmark Results
103 benchmarks: 18 faster, 24 slower, 61 within noise (10%)
Full benchmark resultsJSON Parsing
JSON Serialization
KeySpec Access
Core Operations
Pipeline Overhead
Record Creation & Serialization
Chain vs Pipe
Line Reading
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xlsxnpm package withexceljsto resolve 2 high-severity Dependabot CVEs on the default branchfromxlsoperation to use exceljs's streaming APITest plan
bun test tests/operations/input/fromxls.test.ts— all fromxls tests passbun test— full suite passes (1541 pass, 0 fail)bun run typecheck— no type errors🤖 Generated with Claude Code