feedback #94
mrtrex2021
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Pros:
has comments in the code
author knows about web sockets
has diverse components (repository, service, DB, CLI, web server)
nice comments on interface methods: all the users of that interface can see its comments
uses golang templates to generate HTMP pages
splits code by functionality
offers CSV encoding of data (the Dial object)
Improvement ideas:
add package comments
add an example of how the config file should look like
it limits main() to a single call:
have main() run continuously
main() repeatedly accepts console commands
the object (commands/service/client) should be instantiated only once
the configs should be read only once
use a library that helps with CLI
code for external server is located in the http package
in the same package as the code for the DialService
have a separate package for the external service, and a separate package for dial service
package wtfd uses package sqlite; inside sqlite the DialService object implements the repository design pattern (not the service design pattern) -> name it dialRepository, not dialService
more diagrams (DB relationshiops, purpose of web sockets, etc)
All reactions