Fixes that workflow reminders of cancelled and rescheduled bookings are still sent#1
Open
sartorijr92 wants to merge 8 commits intobase/pr-7232from
Open
Fixes that workflow reminders of cancelled and rescheduled bookings are still sent#1sartorijr92 wants to merge 8 commits intobase/pr-7232from
sartorijr92 wants to merge 8 commits intobase/pr-7232from
Conversation
added 8 commits
February 16, 2023 17:41
Author
|
@kody start-review |
Author
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes that workflow emails are still sent for cancelled and rescheduled bookings. The fix of PR calcom#6991 was wrong and didn't work as expected.
The SendGrid endpoint
DELETE /v3/user/scheduled_sends/${referenceId}was not used correctly. This endpoint deletes a cancelled scheduled email fromscheduled_sendsby removing the 'cancel' status (so email will again be scheduled).The reason why cancelling our scheduled emails stopped working is that all cancerlled emails are saved in
scheduled_sendsuntil the scheduled date but the max. of pending cancellations is 100. Once we reached 100 pending cancellations, new cancellations failed and emails were still sent out.The solution implemented in this PR:
cancelledis added to theworkflowRemindermodelscheduleEmailRemindersis responsible for the final cancellation of the scheduled email (runs every 15 mins)Fixes calcom#7225
Environment: Staging(main branch) / Production
Type of change