Enabled monitors #14
Merged
Enabled monitors #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func queryHandler(w http.ResponseWriter, r *http.Request) { | ||
| entryString := os.Getenv("MYSQL_USER")+":"+os.Getenv("MYSQL_USER_PASSWORD")+"@"+"tcp("+os.Getenv("MYSQL_HOST")+":3306)/"+os.Getenv("MYSQL_DB_NAME") | ||
| //entryString := os.Getenv("MYSQL_USER")+":"+os.Getenv("MYSQL_USER_PASSWORD")+"@"+"tcp("+os.Getenv("MYSQL_HOST")+":"+os.Getenv("MYSQL_PORT")+")/"+os.Getenv("MYSQL_DB_NAME") | ||
| entryString := "root:PASSWORD@tcp(dockerVM:3306)/stuff" |
| return | ||
| default: | ||
| stat := (<-container.statsChannel) | ||
| if(stat == nil) {panic("Received Nil from container")} |
Member
There was a problem hiding this comment.
Why this require a panic error?
Contributor
Author
There was a problem hiding this comment.
@VincenzoFerme Because a nil means the socket isn't receiving anything, which seems to imply something has gone seriously wrong with the docker socket.
Member
There was a problem hiding this comment.
@Cerfoglg Can this happen during the execution or only when the execution starts? I guess the first, right? If that is the case I would say we need a better way to handle this error, by reporting the status to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11