-
Notifications
You must be signed in to change notification settings - Fork 16
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
We can remove Store interface
Following reasons:
- Clean() is implemented only on the local, Done only on the remote
- ctx was added to the interface only for the remote store purpose
- In the code they are always used separately so no polymorphism is happening.
- existence of "not implemented" methods on both implementations
1 & 2 show they really are different behaviours so no benefit of having this interface. Adding new functionalities to one implementation forces us to add params to the second one.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request