Skip to content

Remove artifact store interface #115

@zuzuleinen

Description

@zuzuleinen

We can remove Store interface

Following reasons:

  1. Clean() is implemented only on the local, Done only on the remote
  2. ctx was added to the interface only for the remote store purpose
  3. In the code they are always used separately so no polymorphism is happening.
  4. existence of "not implemented" methods on both implementations

1 & 2 show they really are different behaviours so no benefit of having this interface. Adding new functionalities to one implementation forces us to add params to the second one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions