Skip to content

V2 webhook updates#14

Merged
rweinberger merged 6 commits intobenchling:mainfrom
keithmacaulay:keith-webhooks-v2-updates
Jul 18, 2024
Merged

V2 webhook updates#14
rweinberger merged 6 commits intobenchling:mainfrom
keithmacaulay:keith-webhooks-v2-updates

Conversation

@keithmacaulay
Copy link
Copy Markdown
Contributor

@rweinberger rweinberger self-requested a review July 10, 2024 17:02
Copy link
Copy Markdown

@rweinberger rweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great, tested it locally and works fine! Just one more thing to add into this PR: we'll soon be releasing the ability to explicitly subscribe to specific webhooks via the manifest. In order to be forwards-compatible with that world, we should augment the manifest.yaml file with the following subscriptions section that includes the two webhooks that this app needs in order to function properly:

subscriptions:
  deliveryMethod: WEBHOOK
  messages:
  - type: v2.canvas.initialized
  - type: v2.canvas.userInteracted

For now, we're still sending all webhooks to existing apps, but we won't be doing that forever. So if we don't make this manifest change to opt in to receiving these webhooks, future example apps created from the manifest will actually no longer receive these webhooks.

Comment thread .gitignore Outdated
Copy link
Copy Markdown

@rweinberger rweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!! 🚢 🚢 and thank you so much for taking the initiative to put this PR up 🎉

@rweinberger rweinberger merged commit 2a46c32 into benchling:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants