Skip to content

PLT - Allow editing of title and axis label#603

Draft
Badr-MOUFAD wants to merge 1 commit intobenchopt:mainfrom
Badr-MOUFAD:editable-plots
Draft

PLT - Allow editing of title and axis label#603
Badr-MOUFAD wants to merge 1 commit intobenchopt:mainfrom
Badr-MOUFAD:editable-plots

Conversation

@Badr-MOUFAD
Copy link
Member

Just scrutinized the Plotly JS documentation.
I find out that it is possible to enable editing of title and axis labels.

Screencast.2023-07-05.16.02.38.mp4

Here is a live preview of the feature.

@apmellot your feedback is valuable!
Also related to #600.

@Badr-MOUFAD
Copy link
Member Author

That being said, I'm not 100% convinced with the features

  • It is not super intuitive
  • The editing is lost when viewing the plot with other params

@tomMoral WDYT?

@Badr-MOUFAD Badr-MOUFAD marked this pull request as draft July 5, 2023 14:36
@mathurinm
Copy link
Contributor

shouldn't this rather be done through a config file?

@codecov-commenter
Copy link

Codecov Report

Merging #603 (6402f1e) into main (8dd23c8) will decrease coverage by 0.72%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   54.67%   53.95%   -0.72%     
==========================================
  Files          43       44       +1     
  Lines        2804     2841      +37     
  Branches      510      520      +10     
==========================================
  Hits         1533     1533              
- Misses       1159     1196      +37     
  Partials      112      112              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants