-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage ? 82.12%
=======================================
Files ? 6
Lines ? 179
Branches ? 0
=======================================
Hits ? 147
Misses ? 21
Partials ? 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
- implement tracer for http client - add request events to the records
5afcbe8 to
2f71931
Compare
c1-ra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small misc nitpicks.
Otherwise good !
- typos - casing - Record.Error: add json:omitempty
64ea687
c1-ra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Implement and add profiling features to the request benchmarks.
Instead of measuring the total duration only, we now have access to a timestamp for each step of an http request.
This will allow for more insightful data for the user.
Example
Local request (
http)Output
[ { "Cost": 0, "Code": 200, "Bytes": 0, "Error": null, "Profile": [ { "Name": "GetConn", "Time": 70 }, { "Name": "DNSStart", "Time": 38155 }, { "Name": "DNSDone", "Time": 836820 }, { "Name": "ConnectStart", "Time": 866851 }, { "Name": "ConnectDone", "Time": 1072322 }, { "Name": "ConnectStart", "Time": 1125989 }, { "Name": "ConnectDone", "Time": 1257758 }, { "Name": "GotConn", "Time": 1290506 }, { "Name": "WroteHeaders", "Time": 1358900 }, { "Name": "WroteRequest", "Time": 1361062 }, { "Name": "GotFirstResponseByte", "Time": 1473155 }, { "Name": "PutIdleConn", "Time": 1528966 } ] } ]Remote request (
https)Output
[ { "Cost": 0, "Code": 200, "Bytes": 1256, "Error": null, "Profile": [ { "Name": "GetConn", "Time": 74 }, { "Name": "DNSStart", "Time": 42508 }, { "Name": "DNSDone", "Time": 10587412 }, { "Name": "ConnectStart", "Time": 10655260 }, { "Name": "ConnectDone", "Time": 89404642 }, { "Name": "TLSHandshakeStart", "Time": 89554213 }, { "Name": "TLSHandshakeDone", "Time": 414801212 }, { "Name": "GotConn", "Time": 415041317 }, { "Name": "WroteHeaders", "Time": 415092642 }, { "Name": "WroteRequest", "Time": 415092837 }, { "Name": "GotFirstResponseByte", "Time": 497572965 } ] } ]Changes
Notes