Add filtering negative feedback in the test set#124
Merged
benfred merged 1 commit intobenfred:masterfrom Jun 19, 2018
ita9naiwa:master
Merged
Add filtering negative feedback in the test set#124benfred merged 1 commit intobenfred:masterfrom ita9naiwa:master
benfred merged 1 commit intobenfred:masterfrom
ita9naiwa:master
Conversation
train_test_split functiion in evaluation.pyx
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In train_test_split function (in evaluation.pyx),
There is no filtering negative feedback there. This might make some (1) wrong predictions hit or (2) result lower recall score because of regarding uninteresting items as interesting ones.