Fix overflow warning in nearest neighbors code#755
Merged
Conversation
During the unittest we were seeing a warning saying
```
tests/knn_test.py::BM25Test::test_rank_items_batch
tests/knn_test.py::BM25Test::test_similar_items_filter
tests/knn_test.py::TFIDFTest::test_rank_items_batch
tests/knn_test.py::TFIDFTest::test_similar_items_filter
tests/knn_test.py::CosineTest::test_rank_items_batch
tests/knn_test.py::CosineTest::test_similar_items_filter
/home/ben/code/implicit/implicit/utils.py:134: RuntimeWarning: overflow encountered in cast
output_scores[i] = batch_scores[:N]
```
This is because the `_batch_call` was generating output in float32, but the
KNN models were returning float64 results. Fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the unittest we were seeing a warning saying
This is because the
_batch_callwas generating output in float32, but the KNN models were returning float64 results. Fix.