perf: load NLTK data lazily on first imperative check#36
Merged
Conversation
Move _ensure_nltk_data() into check_imperative() so NLTK models are only loaded when an imperative check actually runs. Avoids the startup cost when imperative is disabled, the range is empty, or subject parsing fails before imperative is reached. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move _ensure_nltk_data() into check_imperative() so NLTK models are
only loaded when an imperative check actually runs. Avoids the startup
cost when imperative is disabled, the range is empty, or subject parsing
fails before imperative is reached.