ci(release): gate PyPI publish behind environment approval#81
Merged
Conversation
Without an environment gate, any tag push immediately publishes to PyPI with no human review step. Adding environment: pypi lets GitHub require manual approval before the job runs, preventing a compromised tag or stolen write token from silently shipping a malicious package. Requires creating the "pypi" environment in Settings → Environments with required reviewers configured before merging. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an environment gate, any tag push immediately publishes to PyPI
with no human review step. Adding environment: pypi lets GitHub require
manual approval before the job runs, preventing a compromised tag or
stolen write token from silently shipping a malicious package.
Requires creating the "pypi" environment in Settings → Environments with
required reviewers configured before merging.