feat(signature): resolve author via Commits API before email search#82
Merged
Conversation
Corporate developers often commit with work emails that are not listed
publicly on their GitHub profile, causing the email-based user search to
return nothing and fail the signature check.
The Commits API (GET /repos/{owner}/{repo}/commits/{sha}) returns
author.login regardless of the commit email, so it resolves work emails,
noreply addresses, and any email that GitHub associates with an account
through the push. When the repo has a GitHub remote and the commit is
already reachable via the API, this path is tried first.
If the API is unavailable (no GitHub remote, commit not yet pushed,
network error, or 404), the check falls back to the existing email
search so pre-commit and non-GitHub workflows are unaffected.
GITHUB_TOKEN or GH_TOKEN can be set for private repository access.
Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corporate developers often commit with work emails that are not listed
publicly on their GitHub profile, causing the email-based user search to
return nothing and fail the signature check.
The Commits API (GET /repos/{owner}/{repo}/commits/{sha}) returns
author.login regardless of the commit email, so it resolves work emails,
noreply addresses, and any email that GitHub associates with an account
through the push. When the repo has a GitHub remote and the commit is
already reachable via the API, this path is tried first.
If the API is unavailable (no GitHub remote, commit not yet pushed,
network error, or 404), the check falls back to the existing email
search so pre-commit and non-GitHub workflows are unaffected.
GITHUB_TOKEN or GH_TOKEN can be set for private repository access.