fix(signature): prevent SSH path from succeeding in GPG verification#84
Merged
Conversation
git auto-detects signature format from the commit object regardless of gpg.format — so _verify_gpg was silently verifying SSH-signed commits via the system gpg.ssh.allowedSignersFile instead of the imported GPG keys, causing it to report "signature type: GPG" for SSH-signed commits. Setting gpg.ssh.allowedSignersFile=/dev/null in the verify-commit call neutralises the SSH path (empty signers file → no principal matches → exit 1) while leaving GPG verification unaffected. The gpg.format=ssh flag in _verify_ssh is kept to ensure SSH format is always used there. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git auto-detects signature format from the commit object regardless of
gpg.format — so _verify_gpg was silently verifying SSH-signed commits via
the system gpg.ssh.allowedSignersFile instead of the imported GPG keys,
causing it to report "signature type: GPG" for SSH-signed commits.
Setting gpg.ssh.allowedSignersFile=/dev/null in the verify-commit call
neutralises the SSH path (empty signers file → no principal matches →
exit 1) while leaving GPG verification unaffected. The gpg.format=ssh
flag in _verify_ssh is kept to ensure SSH format is always used there.