fix(pet-conda): shorten Windows test fixture path#1
Open
benogeorge wants to merge 1 commit intomainfrom
Open
Conversation
Rename the long conda fixture root so Windows GitHub Actions checkouts stay under the path limit. Keep the history-based manager detection test coverage intact while avoiding the cargo fetch failure reported in microsoft#171. Fixes microsoft#171 Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR shortens the conda test fixture directory name to avoid Windows path-length failures in CI while preserving history-based conda manager detection coverage.
Changes:
- Renames the long conda-history fixture root to
conda_histand updates the corresponding Rust test to use the new path. - Adds/relocates conda installation fixture metadata under the shorter path so
is_conda_install()and version parsing continue to work. - Introduces a
history_templatefixture used to generate a runtime-correctconda-meta/historyfor the test.
Reviewed changes
Copilot reviewed 2 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/pet-conda/tests/lib_test.rs | Updates fixture paths used by the history-based manager detection test. |
| crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history | Updates the sample conda history content to reference the new fixture location. |
| crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history_template | Adds a template history file with <CONDA_INSTALL> placeholder for runtime substitution in tests. |
| crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python_abi-3.12-4_cp312.json | Adds conda-meta package fixture data for the env. |
| crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python-dateutil-2.8.2-pyhd8ed1ab_0.json | Adds conda-meta package fixture data for the env. |
| crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/history | Adds the conda install’s history fixture used for install-dir identification. |
| crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/conda-23.1.0-py310hca03da5_0.json | Adds conda package metadata fixture used to infer manager version/arch. |
| crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/conda-build-3.23.3-py310hca03da5_0.json | Adds additional conda install metadata fixture. |
| crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/pytest-7.1.2-py310hca03da5_0.json | Adds additional conda install metadata fixture. |
| crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-dateutil-2.8.2-pyhd3eb1b0_0.json | Adds additional conda install metadata fixture. |
| crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-fastjsonschema-2.16.2-py310hca03da5_0.json | Adds additional conda install metadata fixture. |
Comments suppressed due to low confidence (1)
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history:5
- The fixture history file hard-codes a GitHub Actions workspace path (
/home/runner/work/...). This makes the fixture non-portable and inconsistent with the other conda history fixtures (which use a generic non-existent user path) and with the newhistory_templateapproach in the test. Consider replacing the hard-coded prefix with the same<CONDA_INSTALL>placeholder (or a generic stable path) so the checked-in fixture content remains environment-independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the long conda fixture root so Windows GitHub Actions checkouts stay under the path limit.
This preserves the history-based manager detection coverage while avoiding the long-path failure reported in microsoft#171.
Fixes microsoft#171
Co-Authored-By: Claude noreply@anthropic.com