Skip to content

fix(pet-conda): shorten Windows test fixture path#1

Open
benogeorge wants to merge 1 commit intomainfrom
fix/pet-conda-long-path
Open

fix(pet-conda): shorten Windows test fixture path#1
benogeorge wants to merge 1 commit intomainfrom
fix/pet-conda-long-path

Conversation

@benogeorge
Copy link
Owner

Rename the long conda fixture root so Windows GitHub Actions checkouts stay under the path limit.

This preserves the history-based manager detection coverage while avoiding the long-path failure reported in microsoft#171.

Fixes microsoft#171
Co-Authored-By: Claude noreply@anthropic.com

Rename the long conda fixture root so Windows GitHub Actions checkouts stay under the path limit.

Keep the history-based manager detection test coverage intact while avoiding the cargo fetch failure reported in microsoft#171.

Fixes microsoft#171
Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 23, 2026 16:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR shortens the conda test fixture directory name to avoid Windows path-length failures in CI while preserving history-based conda manager detection coverage.

Changes:

  • Renames the long conda-history fixture root to conda_hist and updates the corresponding Rust test to use the new path.
  • Adds/relocates conda installation fixture metadata under the shorter path so is_conda_install() and version parsing continue to work.
  • Introduces a history_template fixture used to generate a runtime-correct conda-meta/history for the test.

Reviewed changes

Copilot reviewed 2 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/pet-conda/tests/lib_test.rs Updates fixture paths used by the history-based manager detection test.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history Updates the sample conda history content to reference the new fixture location.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history_template Adds a template history file with <CONDA_INSTALL> placeholder for runtime substitution in tests.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python_abi-3.12-4_cp312.json Adds conda-meta package fixture data for the env.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python-dateutil-2.8.2-pyhd8ed1ab_0.json Adds conda-meta package fixture data for the env.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/history Adds the conda install’s history fixture used for install-dir identification.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/conda-23.1.0-py310hca03da5_0.json Adds conda package metadata fixture used to infer manager version/arch.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/conda-build-3.23.3-py310hca03da5_0.json Adds additional conda install metadata fixture.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/pytest-7.1.2-py310hca03da5_0.json Adds additional conda install metadata fixture.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-dateutil-2.8.2-pyhd3eb1b0_0.json Adds additional conda install metadata fixture.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-fastjsonschema-2.16.2-py310hca03da5_0.json Adds additional conda install metadata fixture.
Comments suppressed due to low confidence (1)

crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history:5

  • The fixture history file hard-codes a GitHub Actions workspace path (/home/runner/work/...). This makes the fixture non-portable and inconsistent with the other conda history fixtures (which use a generic non-existent user path) and with the new history_template approach in the test. Consider replacing the hard-coded prefix with the same <CONDA_INSTALL> placeholder (or a generic stable path) so the checked-in fixture content remains environment-independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pet crate can't be fetched by cargo in GitHub Actions machine with Windows

2 participants