fix: handle @ symbols in URL credentials per RFC 3986 (#657)#803
Merged
fix: handle @ symbols in URL credentials per RFC 3986 (#657)#803
Conversation
The userinfo in a URL ends at the LAST @ symbol before the host, not the first. This allows usernames and passwords to contain @ characters. Example: https://user@domain.com:p@ssword@host.com/path - userinfo: user@domain.com:p@ssword - host: host.com The fix uses binary:split with [global] to find all @ symbols, then takes the last part as the netloc and rejoins the rest as credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@characters in username or password@before the hosthttps://user@domain.com:p@ssword@host.com/pathnow correctly parses as:user@domain.comp@sswordhost.comFixes #657