Misc. fixes for non-Windows builds#27
Merged
benstone merged 3 commits intobenstone:mainfrom Mar 26, 2026
Merged
Conversation
…ignal duration Use the KSIGNAL_INFINITE define instead of using the hardcoded 0xffffffff value everywhere.
In the case where FNI::FBuildFromPath() is called with a simple filename, ensure that the filename is converted to an absolute path using the current directory. Otherwise we find relative paths are generated, which do not work correctly when being used with different path prefixes. Also adjust FNI::FGetCwd() to pass an empty string to FNI::FBuildFromPath() to avoid introducing an extra "." (relative directory reference) into the generated path.
…ction The existing code uses fluid_synth_all_notes_off() to reset any playing notes, but this does not reset controllers back to their default values. This can be seen when playing two sounds one after another with an active pitch bend: the second sound starts with the pitch bend still active. Update the code to use fluid_synth_system_reset() instead which not only clears any active notes, but also resets all controllers back to their default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a small series containing some minor fixes for non-Windows builds related to my recent work. The last patch fixes an issue reported to me privately by @benstone when testing the new FluidSynth MIDI playback code.