Skip to content

patch: backports module availability for transformers<4.18#3775

Merged
aarnphm merged 2 commits intobentoml:mainfrom
aarnphm:patch/transformers-function-support
Apr 20, 2023
Merged

patch: backports module availability for transformers<4.18#3775
aarnphm merged 2 commits intobentoml:mainfrom
aarnphm:patch/transformers-function-support

Conversation

@aarnphm
Copy link
Copy Markdown
Contributor

@aarnphm aarnphm commented Apr 19, 2023

What does this PR address?

Patching the available check for transformers 4.18

Signed-off-by: Aaron 29749331+aarnphm@users.noreply.github.com

Before submitting:

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner April 19, 2023 23:22
@aarnphm aarnphm requested review from parano, sauyon and ssheng and removed request for a team April 19, 2023 23:22
Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
Copy link
Copy Markdown
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Just want to make sure signatures inference will be disabled is for version less than 4.17. And is_tf_available etc. is not available for version less than 4.18. Is that right? Because these 2 versions are so close.

@aarnphm
Copy link
Copy Markdown
Contributor Author

aarnphm commented Apr 20, 2023

Oh no, the signature here are since processing_utils only available since 4.18

@aarnphm aarnphm merged commit 0107ead into bentoml:main Apr 20, 2023
@aarnphm aarnphm deleted the patch/transformers-function-support branch April 20, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants