-
Notifications
You must be signed in to change notification settings - Fork 2
Update schema dependency and update sample data files accordingly #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema dependency and update sample data files accordingly #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project to use a specific version of the bertron-schema dependency and ensures test data files comply with the updated schema. It also includes minor improvements to deprecation warnings and test documentation.
- Pin bertron-schema dependency to a specific commit hash instead of using the latest version
- Update JSON test data files to use new schema field names (removing "has_" prefixes)
- Replace deprecated
datetime.utcnow()withdatetime.now(UTC)to eliminate pytest warnings
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates bertron-schema dependency to specific commit with detailed comments |
| tests/data/nmdc-example.json | Updates field names to match new schema (removes "has_" prefixes) |
| tests/data/monet-example.json | Updates field names to match new schema (removes "has_" prefixes) |
| tests/data/gold-example.json | Updates field names to match new schema (removes "has_" prefixes) |
| mongodb/ingest_data.py | Replaces deprecated datetime function and updates schema URL to match dependency |
| CONTRIBUTING.md | Adds instructions for running tests in container with colored output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jeff-cohere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the helpful comments explaining how to maintain the schema dependencies, Eric!
On this branch, I made three main changes:
bertron-schemarepository.has_prefix from some field names.I also made these minor changes:
pytestoutput appears in color, like this: