docs: add deep-dive analysis and verification plan for open issues#184
Merged
Conversation
Appends a Status in fork subsection to each of the 37 upstream issues with a verdict, file:line evidence, and next steps; adds a Status overview table summarising verdicts across all issues.
Appends a per-issue Deep-dive analysis block to each of the 9 LIKELY FIXED / PARTIALLY FIXED entries, and adds a top-level Deep-dive verdict guide categorising which issues are confirmable from code inspection, which need one targeted JUnit test, and which genuinely require platform-specific runtime reproduction. Updates the Status overview table for #121 (FIXED for 64-bit Android) and #86 (CUDA jar requires libcudart at runtime, not auto-fallback).
Fetched verbatim text of the LIKELY FIXED / PARTIALLY FIXED issues from github.com/kherud/java-llama.cpp and append a Verification plan section with: (a) a table of new info extracted from each issue body, (b) four concrete JUnit test sketches that would close out #80, #95, #98, #102, (c) a non-unit-testable bucket for #34, #50, #86, #103, #121 with the corresponding action (feature, docs, CI matrix), (d) a recommended PR sequencing. Notable finding: #98's original repro did not call enableEmbedding() at all — the binding never forwarded --embedding to the upstream server-context, so the result_output assertion fired because the embedding pipeline was never initialised. enableEmbedding() now exists in ModelParameters (line 1040), so the fix is essentially code-confirmed; an integration test against nomic-embed-text is optional confirmation.
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive deep-dive analysis and verification plan to the open issues document. This includes:
Deep-dive verdict guide (new section): categorizes 9
LIKELY/PARTIALLY FIXEDissues into three groups:Per-issue status updates: adds
**Status in fork:**and**Deep-dive analysis:**blocks to 30+ issues with:Status overview table: quick-reference matrix of all 40 issues with verdict, short status, and key evidence
Verification plan: concrete test plan for closing out 4
LIKELY FIXEDissues (Segfault on model open and close kherud/java-llama.cpp#80, This doesn't seem like a good way to do it, and it leads to inference content repetition that can't be ended. kherud/java-llama.cpp#95, Native call to 'delete' doesn't free memory kherud/java-llama.cpp#102, Error loading embedding model nomic-embed-text-v1.5.f16.gguf kherud/java-llama.cpp#98) with:Test plan
Related issues / PRs
Refs kherud#124, kherud#123, kherud#121, kherud#120, kherud#119, kherud#117, kherud#116, kherud#113, kherud#112, kherud#111, kherud#110, kherud#107, kherud#104, kherud#103, kherud#102, kherud#101, kherud#98, kherud#95, kherud#91, kherud#90, kherud#89, kherud#88, kherud#87, kherud#86, kherud#85, kherud#84, kherud#83, kherud#82, kherud#81, kherud#80, kherud#79, kherud#78, kherud#77, kherud#72, kherud#70, kherud#50, kherud#34
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdhttps://claude.ai/code/session_01KA24XD7cLiPVCmo8MaJcMR