Skip to content

fix(publish): quote gate job names to avoid YAML colon-in-scalar error#53

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/fix-release-gate-DBnlS
May 14, 2026
Merged

fix(publish): quote gate job names to avoid YAML colon-in-scalar error#53
bernardladenthin merged 1 commit into
mainfrom
claude/fix-release-gate-DBnlS

Conversation

@bernardladenthin
Copy link
Copy Markdown
Owner

No description provided.

@bernardladenthin bernardladenthin merged commit 7f8dd7d into main May 14, 2026
5 checks passed
@claude
Copy link
Copy Markdown

claude Bot commented May 14, 2026

Review Summary

Approved — This is a correct and necessary fix.

What the PR does

Quotes job names containing colons in the publish workflow to prevent YAML parsing errors. In YAML, unquoted colons in scalar values have special meaning (key-value separator), so values containing colons must be quoted.

Strengths

  • Correct fix: Both job names with colons (Check: main branch / SNAPSHOT and Check: v* tag) are now properly quoted
  • Comprehensive: All affected job names were identified and fixed
  • Minimal: No unnecessary changes; exactly addresses the issue
  • Clear commit message: Explains the problem and solution

Additional observations

  • No other unquoted job names with colons exist in the workflow
  • This fix will prevent potential CI/CD failures from YAML parse errors
  • All other job naming conventions are consistent

The fix is ready and properly merged.

@bernardladenthin bernardladenthin deleted the claude/fix-release-gate-DBnlS branch May 14, 2026 17:43
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.58%. Comparing base (65a1ada) to head (e185b06).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #53   +/-   ##
=========================================
  Coverage     97.58%   97.58%           
  Complexity       93       93           
=========================================
  Files             1        1           
  Lines           248      248           
  Branches         32       32           
=========================================
  Hits            242      242           
  Partials          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage is 100.0%claude/fix-release-gate-DBnlS into main. No base build found for main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants