Make giggsey/libphonenumber-for-php an optional dependency#578
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.x #578 +/- ##
=========================================
Coverage 92.73% 92.74%
- Complexity 1578 1579 +1
=========================================
Files 150 150
Lines 3745 3747 +2
=========================================
+ Hits 3473 3475 +2
Misses 272 272 |
|
@jeromegamez looks good to me, that was fast! I wasn't sure if you preferred to throw an exception if the library was not installed, but given the size of the library, I think it makes sense to make it 100% optional. |
Member
Author
|
An exception would have caused a breaking change and I'm not ready for a new major release yet 😅 Some might argue that this is also a breaking change, when a project uses the library as a transient dependency, but I already have a response prepared for that 😬 I'll merge the PR and create a new minor release soon 💪 |
|
Awesome, thanks :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #577