This repository was archived by the owner on Apr 30, 2026. It is now read-only.
[Engineer] feat(engineer): implement issue-92 plan#102
Open
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
[Reviewer Workflow]
Reviewer: Tech Lead
- If org ruleset listing/fetch fails (e.g. insufficient token scope or API error), the script still concludes FAIL when no active ruleset is found, even though org rulesets were not evaluated. This can generate false drift alerts in org-owned repos. Suggestion: when any org ruleset request fails, mark the result as INCONCLUSIVE/WARN (or skip FAIL) and surface the warning prominently so operators can fix permissions before flagging drift.
d255d6f to
514610b
Compare
There was a problem hiding this comment.
[Reviewer Workflow]
Reviewer: Tech Lead
scripts/workflows/ruleset-verify/ensure-default-branch-ruleset.sh: when multiple rulesets apply to the default branch, the script updates the first one returned by the API, which is not deterministic and may target the wrong ruleset. Suggest filtering byRULESET_NAME(or ID) and failing fast if multiple matches remain.scripts/workflows/ruleset-verify/ensure-default-branch-ruleset.sh: updates always forceenforcement: "active", which can unintentionally enable a ruleset that was previouslyevaluateordisabled. Suggest preserving the existing enforcement unless an explicit env flag requests activation.
29c82b5 to
cf7bc95
Compare
cf7bc95 to
0baa248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Engineer]
自动执行计划任务的实现 PR。
plans/92-default-branch-ruleset-verify.mdCloses #92