Skip to content
This repository was archived by the owner on Apr 30, 2026. It is now read-only.

[Engineer] feat(engineer): implement issue-92 plan#102

Open
bestony wants to merge 1 commit intomainfrom
engineer/92-default-branch-ruleset-verify
Open

[Engineer] feat(engineer): implement issue-92 plan#102
bestony wants to merge 1 commit intomainfrom
engineer/92-default-branch-ruleset-verify

Conversation

@bestony
Copy link
Copy Markdown
Owner

@bestony bestony commented Feb 21, 2026

[Engineer]

  • Workflow: Engineer

自动执行计划任务的实现 PR。

Closes #92

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Reviewer Workflow]
Reviewer: Tech Lead

  • If org ruleset listing/fetch fails (e.g. insufficient token scope or API error), the script still concludes FAIL when no active ruleset is found, even though org rulesets were not evaluated. This can generate false drift alerts in org-owned repos. Suggestion: when any org ruleset request fails, mark the result as INCONCLUSIVE/WARN (or skip FAIL) and surface the warning prominently so operators can fix permissions before flagging drift.

@bestony bestony force-pushed the engineer/92-default-branch-ruleset-verify branch 4 times, most recently from d255d6f to 514610b Compare February 21, 2026 07:45
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Reviewer Workflow]
Reviewer: Tech Lead

  • scripts/workflows/ruleset-verify/ensure-default-branch-ruleset.sh: when multiple rulesets apply to the default branch, the script updates the first one returned by the API, which is not deterministic and may target the wrong ruleset. Suggest filtering by RULESET_NAME (or ID) and failing fast if multiple matches remain.
  • scripts/workflows/ruleset-verify/ensure-default-branch-ruleset.sh: updates always force enforcement: "active", which can unintentionally enable a ruleset that was previously evaluate or disabled. Suggest preserving the existing enforcement unless an explicit env flag requests activation.

@bestony bestony force-pushed the engineer/92-default-branch-ruleset-verify branch 2 times, most recently from 29c82b5 to cf7bc95 Compare February 21, 2026 08:45
@bestony bestony force-pushed the engineer/92-default-branch-ruleset-verify branch from cf7bc95 to 0baa248 Compare February 21, 2026 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Default Branch Ruleset Verify] default branch merge gate drift detected

1 participant