Remove flickering when fix is unstable #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
previously approved these changes
Apr 3, 2019
Member
mikeller
left a comment
mikeller
left a comment
There was a problem hiding this comment.
Heh, that was simpler than I thought it would be. Thanks!
Member
Author
|
No, I forgot to add and alternate icon or similar... now it simply does not move... I will look into it a little more... |
Member
|
@McGiverGim: Good point. But even without that stopping the flickering makes it a lot more usable, so if you don't have time to look into the icon I think we should merge it as it is. |
McGiverGim
force-pushed
the
fix_flickering_gps
branch
from
8e27152 to
1c751a2
Compare
McGiverGim
force-pushed
the
fix_flickering_gps
branch
from
1c751a2 to
4391ea8
Compare
Member
Author
|
Done, I'm not a good icon designer, so no problem if someone wants to make it better ;) |
Member
|
Looks good to me. I think having the question mark go on and off is all that's really needed. |
mikeller
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1309