fix a deprecation in jQuery 3.0 (Firmware flasher tab) #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://api.jquery.com/jQuery.ajax/#jqXHR jqXHR.error() callback removed.
mikeller
approved these changes
Aug 9, 2019
Contributor
Author
|
Oh this might be related to why my Firmware cache journal got thrown out. Just leaving this as a note for later. |
Docteh
added a commit
to Docteh/betaflight-configurator
that referenced
this pull request
Aug 16, 2019
Cleaning up some errors in the javascript console before I start adding new ones. src/js/ConfigStorage.js: forgot to test writing multiple keys at once, can now write multiple keys at once. src/js/FirmwareCache.js: avoid throwing an error if someone comes asking for an undefined firmware src/js/jenkins_loader.js: same .error deprecation as betaflight#1568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now anyone clicking on the Firmware flasher tab gets a nasty looking error in the javascript console, starting with:
Error in response to storage.get: TypeError: $.get(...).error is not a functionhttps://api.jquery.com/jQuery.ajax/#jqXHR
jqXHR.error() callback removed.