Fixed timeout closing of 'Reset to custom defaults' dialog. #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McGiverGim
approved these changes
May 3, 2020
Member
|
Thanks for looking into it!!Now I can see everything even clearer, with this code we manage to respect 100% of the current init timeout. We can also call the timeout when we want just using your new function |
Member
Author
|
Wohooo, that was #2000 by the way, good work everybody, keep them coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1990.
@asizon: Turns out this one is a bit more complex: The problem warning just pops a dialog, but then proceeds to finish the connection, which also removes the timer. In the case of the 'Reset to defaults' dialog we don't want to finish the connection, as the most likely outcome is that the user will want to reset, so we need to remove the timer, and then restart it in the case that the user cancels and we complete the connection.