-
-
Couldn't load subscription status.
- Fork 1k
Updated NW.js to 44.6. #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NW.js to 44.6. #2074
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I think is better to go to latest stable from #1989 now that we have a lot of time to find bugs until next release.
|
@McGiverGim: I think it makes sense to keep the NW.js versions for configurator and blackbox log viewer the same, like we always have - this way we won't have to find bugs twice. |
|
Ahhhh! Maybe we have the same chrome/nw bug that in Configurator? Then we need to fix it in the Blackbox first. Right? |
|
Yes, a lot of the bugs are the same, but blackbox log viewer normally takes longer to update because we have to wait for the ffmpeg libraries to become available - at the moment, 44 is the latest version actually working with the ffmpeg libraries. |
|
I was talking about this #1982 |
|
I didn't remember the ffmpeg libraries... Good catch! |
|
I was bitten too often by forgetting them, and then having to roll back - it's taught me. But yes, we will have to look into this for blackbox log viewer as well, I feel that moving to NW windows is the way forward. And seeing the announced end date for support of Chrome Web apps, it probably makes sense to axe this now - we only have all of 159 users for it anyway. |
|
Only as curiosity: I think the developer only publishes a new version when it is not compatible or there are changes. For this reason sometimes there are versions for linux but not for windows, etc. |
|
@McGiverGim: I have already tested the current and the latest versions of the ffmpeg libraries against NW.js 0.45 and 0.46 - all without success. :-( |
To go with betaflight/blackbox-log-viewer#449.