Skip to content

Conversation

@mikeller
Copy link
Member

@mikeller mikeller added this to the 10.8.0 milestone Jun 21, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I think is better to go to latest stable from #1989 now that we have a lot of time to find bugs until next release.

@mikeller
Copy link
Member Author

@McGiverGim: I think it makes sense to keep the NW.js versions for configurator and blackbox log viewer the same, like we always have - this way we won't have to find bugs twice.

@McGiverGim
Copy link
Member

Ahhhh! Maybe we have the same chrome/nw bug that in Configurator? Then we need to fix it in the Blackbox first. Right?

@mikeller
Copy link
Member Author

Yes, a lot of the bugs are the same, but blackbox log viewer normally takes longer to update because we have to wait for the ffmpeg libraries to become available - at the moment, 44 is the latest version actually working with the ffmpeg libraries.

@McGiverGim
Copy link
Member

I was talking about this #1982

@McGiverGim
Copy link
Member

I didn't remember the ffmpeg libraries... Good catch!

@mikeller
Copy link
Member Author

mikeller commented Jun 21, 2020

I was bitten too often by forgetting them, and then having to roll back - it's taught me.

But yes, we will have to look into this for blackbox log viewer as well, I feel that moving to NW windows is the way forward. And seeing the announced end date for support of Chrome Web apps, it probably makes sense to axe this now - we only have all of 159 users for it anyway.

@McGiverGim
Copy link
Member

Only as curiosity: I think the developer only publishes a new version when it is not compatible or there are changes. For this reason sometimes there are versions for linux but not for windows, etc.
I have updated (and we published it) sometimes the nw.js version with older ffmpeg libraries (because there were not a new one) and it worked.
If you want I can test if this is true with the latest version.

@mikeller
Copy link
Member Author

@McGiverGim: I have already tested the current and the latest versions of the ffmpeg libraries against NW.js 0.45 and 0.46 - all without success. :-(

@mikeller mikeller merged commit be8d59e into betaflight:master Jun 22, 2020
@mikeller mikeller deleted the update_nw_js_to_44_6 branch June 22, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants