Added Vbat Sag Compensation to UI #2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McGiverGim
requested changes
Jul 3, 2020
McGiverGim
previously approved these changes
Jul 3, 2020
|
Making some changes in the tooltip, please dont merge yet |
Remove empty white line Improve ff and vbatSag functions change events Tooltip reviewing
asizon
force-pushed
the
add_vbatSagCompensation_to_ui
branch
from
85df854 to
18e8474
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Done, updated tooltip as @ctzsnooze requested and added % after number box
|
McGiverGim
approved these changes
Jul 3, 2020
mikeller
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Vbat Sag Compensation to UI, when its enabled the sag value goes to default standard of 100 else it goes to 0(disabled).