-
-
Couldn't load subscription status.
- Fork 1k
Add support for British units in OSD #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for British units in OSD #2146
Conversation
|
Added Celsius / Fahrenheit to British unit. |
d8704fa to
31bd2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the two Sonar issues, apart of this, the PR seems ok to me.
Maybe is better to start using the constants and not the position in the conditions, to make the code clearer. Is not needed for this PR, but I think it will left a better code.
31bd2f2 to
24dd653
Compare
24dd653 to
cb67ffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good to me!!!
|
It seems Travis is failing downloading the innosetup package... I will check to see if it is only Travis or is a general error... :( |
|
It seems only a Travis problem... the url https://registry.yarnpkg.com/@quanle94/innosetup/-/innosetup-6.0.2.tgz works perfectly for me. I think is the URL that appears in the logs because is the first betaflight-configurator/package.json Lines 65 to 69 in 9edff49
|
cb67ffd to
e36f3cb
Compare
|
Now I am happy too. I missed two occasions. Fixed also. Including forgotten ; Also Travis is fine now too.
|
e36f3cb to
3172183
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
On slack there was a demand for a British unit for speed and distance related elements in OSD.
It's tested on a IFLIGHT SUCCEX-D F7 TWING with DJI goggles and this PR adds visibility in OSD preview.
Units
Affected OSD Elements
Firmware part: betaflight/betaflight#10080