Add IRC Ghost Serial Rx Protocol #2185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Api version 1.44 and later
|
Usually is a good idea to reference the firmware PR: betaflight/betaflight#10217 |
McGiverGim
approved these changes
Sep 29, 2020
asizon
requested changes
Sep 29, 2020
src/js/fc.js
Outdated
| result.push('SPEKTRUM SRXL2'); | ||
| } | ||
|
|
||
| if (semver.gte(apiVersion, "1.44.0")) { |
There was a problem hiding this comment.
We are using now a new API_VERSION constant here.
There was a problem hiding this comment.
Thanks guys, just to confirm, you are suggesting replacing the "1.44.0" with API_VERSION_1_44 right?
McGiverGim
requested changes
Sep 29, 2020
"1.44.0" -> API_VERSION_1_44
|
Kudos, SonarCloud Quality Gate passed!
|
McGiverGim
approved these changes
Oct 14, 2020
mikeller
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable 'IRC Ghost' protocol for Api version 1.44 and later. Will be accompanied by a similar PR in betaflight to install the driver.