-
-
Couldn't load subscription status.
- Fork 1k
Update FF Interpolate default #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one question...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose you want to say change from Average 2 to NO average (and not ON). It's ok to me.
<select id="ffInterpolate">
<option i18n="pidTuningFfInterpolateSpOptionNoAverage" value="1">
<option i18n="pidTuningFfInterpolateSpOptionAverage2" value="2"/>
<option i18n="pidTuningFfInterpolateSpOptionAverage3" value="3"/>
<option i18n="pidTuningFfInterpolateSpOptionAverage4" value="4"/>
</select>One suggestion (not mandatory) to make it easier to read:
const NO_AVERAGE = 1;
$('select[id="ffInterpolate"]').val(FC.ADVANCED_TUNING.ff_interpolate_sp > 0 ? FC.ADVANCED_TUNING.ff_interpolate_sp : NO_AVERAGE);|
@McGiverGim yes sorry, ON is the value in cli for No Average. Make a constant for the default and better reads sound good. |
|
SonarCloud Quality Gate failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. When the "constant" is only used at one place, usually is good to place it just the line before the use.
To go with betaflight/betaflight#10164
It updates ff_interpolate_sp default value from average 2 to No Average.