Add Thrust Linearization #2218
Merged
Add Thrust Linearization #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Thrust Linearization to the PID Tuning tab.
klutvott123
force-pushed
the
add-thrust-linear
branch
from
faa136a to
55c106b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
haslinghuis
requested changes
Oct 11, 2020
| .push8(FC.ADVANCED_TUNING.ff_smooth_factor) | ||
| .push8(FC.ADVANCED_TUNING.ff_boost) | ||
| .push8(FC.ADVANCED_TUNING.vbat_sag_compensation); | ||
| .push8(FC.ADVANCED_TUNING.vbat_sag_compensation) |
There was a problem hiding this comment.
Suggested change
| .push8(FC.ADVANCED_TUNING.vbat_sag_compensation) | |
| .push8(FC.ADVANCED_TUNING.vbat_sag_compensation); |
There was a problem hiding this comment.
Hmm. I don't think so. Everything inside this if is just one statement and the semicolon should be at the end?
There was a problem hiding this comment.
Oops, don't know how I missed the next line
haslinghuis
approved these changes
Oct 12, 2020
| .push8(FC.ADVANCED_TUNING.ff_smooth_factor) | ||
| .push8(FC.ADVANCED_TUNING.ff_boost) | ||
| .push8(FC.ADVANCED_TUNING.vbat_sag_compensation); | ||
| .push8(FC.ADVANCED_TUNING.vbat_sag_compensation) |
There was a problem hiding this comment.
Oops, don't know how I missed the next line
mikeller
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Thrust Linearization to the PID Tuning tab.
PR for firmware side betaflight/betaflight#10268