Change lexical scope serial #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
Dec 13, 2020
src/js/port_handler.js
Outdated
| callback(self.dfu_available); | ||
| } | ||
| if (!$('option:selected', self.portPickerElement).data().isDFU) { | ||
| if (!GUI.connected_to) { |
src/js/serial.js
Outdated
| self.getInfo(function (info) { | ||
| if (info) { | ||
| if (info.paused) { | ||
| self.getInfo(function (getInfo) { |
There was a problem hiding this comment.
This rename seems to make the code less intuitive and harder to read (getInfo would be a getter for info, and not for getInfo).
There was a problem hiding this comment.
info is already used in upper scope. Like to have an exclusive object for the function. Changed it to _info
src/js/serial.js
Outdated
| } | ||
|
|
||
| console.log(`${self.connectionType}: send buffer overflowing, dropped: ${counter} ${entries}`); | ||
| console.log(`${self.connectionType}: send buffer overflowing, dropped: ${counter}`); |
src/js/serial_backend.js
Outdated
| else | ||
| $(".failsafeicon").removeClass('active'); | ||
| } | ||
| for (const index in FC.AUX_CONFIG) { |
|
Thanks. Fixed as requested per review |
|
SonarCloud Quality Gate failed.
|
mikeller
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.