Change lexical scope tuning #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
Dec 13, 2020
src/js/tabs/pid_tuning.js
Outdated
| // Add a name to each row of PIDs if empty | ||
| $('.pid_tuning tr').each(function(){ | ||
| for(i = 0; i < FC.PID_NAMES.length; i++) { | ||
| for (const i in FC.PID_NAMES) { |
| } else { | ||
| console.log(`Unsupported API version: ${FC.CONFIG.apiVersion}`); | ||
| } | ||
| return promise; |
src/js/tabs/pid_tuning.js
Outdated
| var rateCurveUpdateRequired = false; | ||
| for(var i=0; i<this.oldRC.length; i++) { // has the value changed ? | ||
| let rateCurveUpdateRequired = false; | ||
| for (let i=0; i<this.oldRC.length; i++) { // has the value changed ? |
src/js/tabs/pid_tuning.js
Outdated
|
|
||
| // check that the balloon does not already overlap | ||
| for(var i=0; i<dirty.length; i++) { | ||
| for(const i in dirty) { |
src/js/tabs/pid_tuning.js
Outdated
| } | ||
| // then display them on the chart | ||
| for(var i=0; i<balloons.length; i++) balloons[i].balloon(); | ||
| for(const i in balloons) { |
|
Fixed as requested per review. Added fixing spaces in several places to be more consistent. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.