Skip to content

Change lexical scope gps #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Change lexical scope gps #2318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/js/tabs/gps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

TABS.gps = {};
TABS.gps.initialize = function (callback) {
var self = this;

if (GUI.active_tab !== 'gps') {
GUI.active_tab = 'gps';
Expand Down Expand Up @@ -43,13 +42,13 @@ TABS.gps.initialize = function (callback) {
}

// To not flicker the divs while the fix is unstable
var gpsWasFixed = false;
let gpsWasFixed = false;

function update_ui() {
var lat = FC.GPS_DATA.lat / 10000000;
var lon = FC.GPS_DATA.lon / 10000000;
var url = 'https://maps.google.com/?q=' + lat + ',' + lon;
var alt = FC.GPS_DATA.alt;
const lat = FC.GPS_DATA.lat / 10000000;
const lon = FC.GPS_DATA.lon / 10000000;
const url = `https://maps.google.com/?q=${lat},${lon}`;
let alt = FC.GPS_DATA.alt;
if (semver.lt(FC.CONFIG.apiVersion, API_VERSION_1_39)) {
alt = alt / 10;
}
Expand All @@ -63,24 +62,24 @@ TABS.gps.initialize = function (callback) {
$('.GPS_info td.distToHome').text(FC.GPS_DATA.distanceToHome + ' m');

// Update GPS Signal Strengths
var e_ss_table = $('div.GPS_signal_strength table tr:not(.titles)');
const eSsTable = $('div.GPS_signal_strength table tr:not(.titles)');

for (var i = 0; i < FC.GPS_DATA.chn.length; i++) {
var row = e_ss_table.eq(i);
for (let i = 0; i < FC.GPS_DATA.chn.length; i++) {
const row = eSsTable.eq(i);

$('td', row).eq(0).text(FC.GPS_DATA.svid[i]);
$('td', row).eq(1).text(FC.GPS_DATA.quality[i]);
$('td', row).eq(2).find('progress').val(FC.GPS_DATA.cno[i]);
}


var message = {
const message = {
action: 'center',
lat: lat,
lon: lon
};

var frame = document.getElementById('map');
frame = document.getElementById('map');
if (navigator.onLine) {
$('#connect').hide();

Expand Down Expand Up @@ -139,19 +138,19 @@ TABS.gps.initialize = function (callback) {
}
});

var frame = document.getElementById('map');
let frame = document.getElementById('map');

$('#zoom_in').click(function() {
console.log('zoom in');
var message = {
const message = {
action: 'zoom_in'
};
frame.contentWindow.postMessage(message, '*');
});

$('#zoom_out').click(function() {
console.log('zoom out');
var message = {
const message = {
action: 'zoom_out'
};
frame.contentWindow.postMessage(message, '*');
Expand Down