Fix drawStickOverlayPreview in OSD #2332
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| return Math.floor(Math.random() * Math.floor(count)); | ||
| } | ||
|
|
||
| const STICK_OVERLAY_SPRITE = [ |
There was a problem hiding this comment.
While this is an improvement, I can not see how this scope change will fix any bugs. Can you explain please?
There was a problem hiding this comment.
The array that's build up in this function had undefined symbols. At first I tried to chase charCode but that was only a subsequent behavior. So very strange I found out that the array I moved was undefined within the function although it was a constant declared outside the block scope.
Cause: SYM.loadSymbols() is not initialized before line 2240 occurs and after the const was created.
There was a problem hiding this comment.
Not sure how this move is relating to SYM.loadSymbols(), as it is not connected in any way. But the change of scope makes sense, so good to go.
2 participants
Fixes: #2330