Skip to content

Conversation

@limonspb
Copy link
Member

@limonspb limonspb commented May 12, 2021

To add your presets, check [this repo] readme: (https://github.com/betaflight/firmware-presets) with presets.

Cool ideas for later improvements - next PRs:

  • Dropdown list of picked presets
  • Load preset from a local file and show a preset dialog with options ETC.
  • Add search order (rank?) #$ attribute for presets - so that we could move, for example, defaults down in the search results

Remaining tasks for the last stage:

  • Ignore #$ HIDDEN: true presets - don't show in search
  • Warning and DIsclaimer dialogs when applying presets of author used #$ WARNING, #$ DISCLAIMER or included messages options
  • When scrolling presets only search parameters should stick to the top, not the whole top panel
  • Proper sizing of the presets tiles without unused space on the right
  • Allow different sources/repositories for presets - user dialog that allows using new sources of presets besides official Betaflight.
  • Official Betaflight presets source should be pointing at api.betaflight.com
  • Make popup windows with the preset wider
  • Show CLI button that runs the #include and #regions algorithm and shows the CLI commands that are going to be applied
  • Add #discussion link for the preset popup window
  • Small warning message at the top of the presets tab
  • Button for presets Wiki at the top
  • Add Backup load/save buttons to save/load the whole users dump into a file.
  • Rename buttons at the bottom and reorder them
  • Move presets Tab higher
  • Lazy CLI initialization - enter CLI mode only when the user actually applies preset
  • CLI errors catch - when preset is being applied with errors - make a warning.
  • Scroll the page down when CLI is shown.
  • Rename Regions -> Options in UI and in the code.
  • Make search line searching words, not the whole phrase
  • TUNE should be selected by default as well as the correct FW version for search.
  • Warning if applying preset from a wrong FW version
  • CLI should be available for copy text as well as CLI in the detailed dialog preview
  • Add magnifying glass icon next to the search string
  • When no presets are found show little element "No presets found for selected search parameters"
  • When too many presets found - show little element at the end "60 showed presets, more was found"
  • Animation on applying a preset
  • Disable save/cancel buttons when no presets are picked
  • Check Android
  • Code cleanup

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just personal preference. Ignore if you like, I just like the density make the code more clear to oversee. Good work!
Did a quick review.

@limonspb limonspb force-pushed the presets branch 3 times, most recently from 7be4e2e to a741f3e Compare June 4, 2021 07:47
@limonspb limonspb added this to the 10.8.0 milestone Jun 11, 2021
@sonarqubecloud

This comment has been minimized.

@limonspb
Copy link
Member Author

The work is mainly done and should be working. Need a couple of touches here and there plus a code beautifying. I will convert draft to a pull request when ready for review.

@sonarqubecloud

This comment has been minimized.

@limonspb limonspb marked this pull request as ready for review September 18, 2021 08:17
@limonspb limonspb marked this pull request as draft September 18, 2021 08:18
@limonspb limonspb force-pushed the presets branch 2 times, most recently from a743718 to de83e42 Compare September 28, 2021 07:46
@haslinghuis
Copy link
Member

@limon please rebase your local branch. stm32.js is already updated and should not giving this errors in here anyway.

@limonspb limonspb marked this pull request as ready for review October 1, 2021 23:17
@limonspb
Copy link
Member Author

limonspb commented Oct 1, 2021

Not ready for review yet. Just building for people who want to try Configurator with presets

@limonspb limonspb marked this pull request as draft October 1, 2021 23:35
@limonspb limonspb marked this pull request as ready for review October 6, 2021 21:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.2% 0.2% Duplication

@ctzsnooze
Copy link
Member

Ready to merge and tested.

Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no words, really awesome and profesional work, thankyou @limonspb

@blckmn
Copy link
Member

blckmn commented Nov 26, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 474ff80 into betaflight:master Nov 26, 2021
@limonspb limonspb deleted the presets branch November 7, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants