Added PT2 and PT3 filter types #2503
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) { | ||
| filterTypeValues.push("PT2"); | ||
| filterTypeValues.push("PT3"); | ||
| } |
There was a problem hiding this comment.
I don't know if I like more this way or only with one push...
| if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) { | |
| filterTypeValues.push("PT2"); | |
| filterTypeValues.push("PT3"); | |
| } | |
| if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) { | |
| filterTypeValues.push("PT2", "PT3"); | |
| } |
There was a problem hiding this comment.
Interesting, but maybe i like the first way to best visual differentation betwen two filters type. Do you think that with a single push the performance will be better?
There was a problem hiding this comment.
I'm not too sure what I prefer, only was a comment 🙃
There was a problem hiding this comment.
I prefer the former as it's easier to understand 🙃
|
I've to change |
|
We need one test and the third approval here to test the new process. Milestone and RN tag is already set. |
|
@blckmn approver count passed? It's two at the moment 😕 The process should not run yet? |
|
AUTOMERGE: (PASS)
|
|
@haslinghuis I dont understund what are you refering with two places. |
I am running it manually at the moment and doing testing :) |
|
Found the problem with the reviewers. If you submit two reviews, it adds you twice. Now counting the unique users who have approved the PR :) |
5 participants
This PR adds new filter type options to PidTuning/Filters Configurator tab, to go with a small part of betaflight/betaflight#10727