Rebase stm32.js #2570
Merged
Rebase stm32.js #2570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
force-pushed
the
fix_lexical_scoping
branch
2 times, most recently
from
7d62218 to
92d4840
Compare
asizon
previously approved these changes
Aug 22, 2021
McGiverGim
previously approved these changes
Aug 23, 2021
ctzsnooze
previously approved these changes
Aug 31, 2021
mikeller
reviewed
Aug 31, 2021
src/js/protocols/stm32.js
Outdated
| // send over the actual data | ||
| serial.send(bufferOut, function (writeInfo) {}); | ||
| serial.send(bufferOut, function (writeInfo) { | ||
| // |
There was a problem hiding this comment.
Looking at src/js/serial.js, callback seems to be optional, so we can probably just omit this.
src/js/protocols/stm32.js
Outdated
| // result = true/false | ||
| STM32_protocol.prototype.verify_flash = function (first_array, second_array) { | ||
| for (var i = 0; i < first_array.length; i++) { | ||
| for (let i = 0; i < first_array.length; i++) { |
There was a problem hiding this comment.
Did you want to fix first_array as well?
src/js/protocols/stm32.js
Outdated
| if (this.receive_buffer.length >= n_bytes) { | ||
| // data that we need are there, process immediately | ||
| var data = this.receive_buffer.slice(0, n_bytes); | ||
| const data = this.receive_buffer.slice(0, n_bytes); |
There was a problem hiding this comment.
Did you want to fix n_bytes as well?
src/js/protocols/stm32.js
Outdated
| // write start address + checksum | ||
| self.send([addressArray[0], addressArray[1], addressArray[2], addressArray[3], addressChecksum], 1, function (_reply) { | ||
| if (self.verify_response(self.status.ACK, _reply)) { | ||
| const ArrayOut = Array.from(bytesToWrite + 2); // 2 byte overhead [N, ...., checksum] |
There was a problem hiding this comment.
Not sure why this is capitalised?
There was a problem hiding this comment.
Yes, as original, fixed now.
haslinghuis
dismissed stale reviews from ctzsnooze, McGiverGim, and asizon
via
11c098e
haslinghuis
force-pushed
the
fix_lexical_scoping
branch
from
92d4840 to
11c098e
Compare
haslinghuis
force-pushed
the
fix_lexical_scoping
branch
from
11c098e to
682539f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do I need to do anything here to get it approved? |
McGiverGim
approved these changes
Sep 19, 2021
blckmn
approved these changes
Sep 25, 2021
limonspb
approved these changes
Sep 26, 2021
|
AUTOMERGE: (PASS)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of stm32.js:
Only one file to go (usbstm32dfu.js)