Skip to content

Conversation

@asizon
Copy link
Member

@asizon asizon commented Aug 22, 2021

Fixes #2569

@asizon asizon force-pushed the convert_serial_protocols_select2 branch from cdaad57 to b83ccdf Compare August 22, 2021 11:22
@asizon asizon changed the title Convert serial based protocols selector to Select2 Convert serial rx and Spi rx protocols selectors to Select2 Aug 22, 2021
@asizon asizon self-assigned this Aug 22, 2021
@asizon asizon added this to the 10.8.0 milestone Aug 22, 2021
haslinghuis
haslinghuis previously approved these changes Aug 22, 2021
McGiverGim
McGiverGim previously approved these changes Aug 23, 2021
@asizon asizon dismissed stale reviews from McGiverGim and haslinghuis via 675e038 August 28, 2021 06:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asizon
Copy link
Member Author

asizon commented Aug 28, 2021

Aplying Select2 for Android breaks selector style for that.

@McGiverGim
Copy link
Member

Aplying Select2 for Android breaks selector style for that.

I suppose it will not fix anything but... have you tried to use the "next" version of the component, the 4.1.0-rc.0 to see if maybe it works for Android? I don't see nothing in the changelog but who knows... https://github.com/select2/select2/blob/master/CHANGELOG.md#410-unreleased

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but as suggestion for the future, as we use it in several places, and usually to order in alphabetical way always, maybe we can create a function that only receives the element as parameter, and it verifies if cordova and adds the select2 alphabetical. It will reduce it to one line.

@blckmn
Copy link
Member

blckmn commented Oct 13, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 88b7c9a into betaflight:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Alphabetize various dropdowns

5 participants