-
-
Couldn't load subscription status.
- Fork 1k
Convert serial rx and Spi rx protocols selectors to Select2 #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert serial rx and Spi rx protocols selectors to Select2 #2575
Conversation
cdaad57 to
b83ccdf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Aplying Select2 for Android breaks selector style for that. |
I suppose it will not fix anything but... have you tried to use the "next" version of the component, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but as suggestion for the future, as we use it in several places, and usually to order in alphabetical way always, maybe we can create a function that only receives the element as parameter, and it verifies if cordova and adds the select2 alphabetical. It will reduce it to one line.
|
AUTOMERGE: (FAIL)
|








Fixes #2569