Skip to content

Fixed parsing of firmware versions to support multi-digit versions. #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fixed parsing of firmware versions to support multi-digit versions. #2615

merged 1 commit into from
Oct 1, 2021

Conversation

@mikeller
Copy link
Member

This would be needed to support the 4.2.10 release. 🤣

@mikeller mikeller added this to the 10.8.0 milestone Sep 30, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@McGiverGim
Copy link
Member

Are we going to release a version of the old Configurator with this?

@haslinghuis
Copy link
Member

Tests ok on Windows and Linux.

@blckmn
Copy link
Member

blckmn commented Oct 1, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 4583ad4 into betaflight:master Oct 1, 2021
@mikeller mikeller deleted the fix_firmware_version_parsing branch October 10, 2021 02:52
@mikeller
Copy link
Member Author

@McGiverGim: I think doing a patch release for configurator to include this will make sense - otherwise we will not be seeing much uptake of the Betaflight 4.2.10 release. I'll look into this.

mikeller pushed a commit that referenced this pull request Oct 11, 2021
@blckmn @mikeller
Auto merged - #2615 at Fri, 01 Oct 2021 21:17:07 GMT
72226a8 
Fixed parsing of firmware versions to support multi-digit versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon asizon approved these changes

+1 more reviewer

@DusKing1 DusKing1 DusKing1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikeller mikeller

Labels

RN: BUGFIX Tested

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mikeller @McGiverGim @haslinghuis @blckmn @DusKing1 @asizon