Prevent changing profiles if settings are not saved

[haslinghuis]

Keep isDirty state consistent with firmware sliders.

Due to firmware sliders we save the current slider state to get PIDs etc loosing state in firmware until saved. So if user does not want to save we are storing and retrieving original state at tab load or using refresh.

Button Reset all profiles resets the isDirty flag so we can change to another profile while settings may have changed in the previous profile which could load saved settings to the wrong profile.

• set isDirty after reset profile button
• reset flags and resulting state after using refresh button.
• reset isDirty when changes are undone.

Problems solved:

• use isDirty and sliderRetainConfiguration flag to keep state and prevent going to another profile without saving.
• Fixes: PID Sliders disappear on rates manual change  #2619 reworked handlers and selectors (rates tab was using same selectors)
• disable input on RP or RPY according to sliderMode. This will users remind to save settings after changing sliderMode.
• Enabling PID sliders respects initial firmware setting (user can use reset profile button for setting sliders to default).

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> PASS
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ctzsnooze]

This works really well! Tests fine on Mac OSX.

1. The Reset all Profile Values button now doesn't auto-save the reset... which is MUCH better behaviour. The user can now hit that button to 'check out' what those defaults would be, without immediately and permanently losing all their current settings. If they want to save the changes from the reset, they must, like any other change, hit the SAVE button if they want to save their changes. This is much more consistent behaviour and a definite improvement.

2. When slider modes are active, clicking on the numbers achieves nothing. This is much better. If the user wants to change a number, they must turn the slider mode off, manually. Values that are not editable are shown in grey, not black.

I'd suggest one small change here, on the Mac, at least, the 'grey' for the non-editable numbers could be made more 'pale'. It didn't stand out so much. Perhaps the same paler grey as used in the PID controller settings sub-text fields?

Apart from that minor suggestion, this is great!

It is possible that, since sliders are now active by default, 'old-timer' users may not figure out why they can't edit the numbers. Perhaps some pop-up on hover over an inactive numeric field could explain that these values are controlled by sliders? Perhaps we can wait until we find out whether this is a real problem from user feedback.

[mikeller]

Tested, seems to be working fine.

[mituritsyn]

Hi guys, seems this pr has some troubles. PID and some rates fields have became inactive.

[haslinghuis]

@mituritsyn - please set RPY to OFF and save to be able to edit PID values manual.

Somehow Rates Roll Center and Expo are also effected (so have to check how this is happening as we use classes for selection).