Split header and fix i18n message #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctzsnooze
previously approved these changes
Oct 14, 2021
asizon
previously approved these changes
Oct 14, 2021
limonspb
requested changes
Oct 14, 2021
src/css/tabs/pid_tuning.css
Outdated
|
|
||
| .tab-pid_tuning .subtab-pid .cf_column { | ||
| min-width: 472px; | ||
| min-width: 600px; /* 472px; */ |
Fix sonar bug Remove comment
haslinghuis
force-pushed
the
split_header
branch
from
3b0ac87 to
4c9fbc6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ctzsnooze
approved these changes
Oct 14, 2021
chmelevskij
approved these changes
Oct 29, 2021
limonspb
approved these changes
Nov 9, 2021
asizon
approved these changes
Nov 9, 2021
|
AUTOMERGE: (PASS)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have enough room to fit all elements on one row if we use an extra header in the first column and adjust width (about 8% + 12%).
Also think we need to adjust the second column to go down on smaller screens at around 600px to fit other labels too.