Skip to content

Conversation

@haslinghuis
Copy link
Member

Bumps NWjs from 0.54.1 to 0.59.0.

Needs testing and hopefully resolves some OSX issues 🤞

@haslinghuis haslinghuis added this to the 10.8.0 milestone Dec 3, 2021
@haslinghuis haslinghuis self-assigned this Dec 3, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctzsnooze
Copy link
Member

ctzsnooze commented Dec 3, 2021

Last minute changing nw.js should only be considered for 4.3 timeline if it definitely fixes a bug.
Let's find out if it does fix something, but we must be aware that it may break some things too.
I think this should be on 10.9 / 4.4 time line.

@blckmn
Copy link
Member

blckmn commented Dec 4, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis modified the milestones: 10.8.0, 10.8.1 Dec 5, 2021
@ctzsnooze
Copy link
Member

Checked, runs on Mac OSX Mojave.
Doesn't solve the Hide issues, so we must keep converting hide to minimise.

@haslinghuis
Copy link
Member Author

Are we sure we don't want to add this to 10.8.0

@asizon
Copy link
Member

asizon commented Dec 22, 2021

If it doesnt solves any issues, i think is best to put i next releases to be sure doesnt break anithing, since we are in the 4.3 teamline.

@haslinghuis haslinghuis merged commit 4b8b221 into betaflight:master Dec 23, 2021
@haslinghuis haslinghuis deleted the update_nwjs branch December 23, 2021 02:04
@haslinghuis haslinghuis modified the milestones: 10.8.1, 10.8.0 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants