Added configuration of KISS ESC Telemetry

[basdelfos]

Configuration tab:

• Added checkbox for feature ESC_TELEMETRY.

Ports tab:

• Added ESC telemetry protocol to telemetry dropdown selection.

Locales:

• Added text and tips to locales (en) message file.

No MSP changes had to be made.

[mikeller]

I think the placement of the ESC telemetry inside the telemetry dropdown needs rethinking. And all of this definitely needs version gating.

[mikeller]

This will have to be wrapped with a if (semver.gte(config.flightControllerVersion, "3.1.0")) version gate.

[mikeller]

Hmm, I think this is wrong.

If you add TELEMETRY_ESC to the telemetry then it will appear in the same drop down as the telemetry protocols that can be used between FC and RX, and will make it impossible to configure ESC telemetry and 'normal' telemetry at the same time. I think what we need is a separate checkbox in the ports matrix for ESC telemetry.

Also, this needs to be version gated for >= 3.1 as well. In general, all new additions need feature gating, to prevent users with older firmware versions from seeing them.

[basdelfos]

As mentioned in dev slack, the whole serial configuration needs rework to make it more logical for users. Boris suggested a while ago to just add ESC telemetry to the existing telemetry dropdown. This also seems the most straight forward solution for now.

The version gate I will add later today and will also check if RX telemetry and ESC telemetry are configurable at the same time on different serial ports.

[mikeller]

I think we should have this added to the UI before we do the ports tab rework. Also, version gates will have to be done before this is merged, because otherwise it makes the configurator non-releasable.

Let me know if I can help with anything.

[basdelfos]

Added version gating and successfully tested with BF 3.0.1 and BF 3.1.0

[basdelfos]

If you add TELEMETRY_ESC to the telemetry then it will appear in the same drop down as the telemetry protocols that can be used between FC and RX, and will make it impossible to configure ESC telemetry and 'normal' telemetry at the same time

Selecting SmartPort and ESC Telemetry on different UARTs is possible. The GUI seems not to check if more than 1 item of the group is selected. I can save and reload without errors or anyone disappearing.

[mikeller]

You are right. It looks like the functionality to consume maxPorts and sharableWith was never implemented, and the configurator relies on the firmware to remove combinations that are not supported.