-
-
Notifications
You must be signed in to change notification settings - Fork 155
Require reboot when changing battery parameters #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
谢谢更新!期待PR处理完,有新标题生成功能好棒~
和而不同
群而不党
---- Replied Message ----
| From | ***@***.***> |
| Date | 10/19/2025 17:37 |
| To | betaflight/betaflight-tx-lua-scripts ***@***.***> |
| Cc | Subscribed ***@***.***> |
| Subject | Re: [betaflight/betaflight-tx-lua-scripts] Require reboot when changing battery parameters (PR #531) |
coderabbitai[bot] left a comment (betaflight/betaflight-tx-lua-scripts#531)
Note
Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Reviewing files that changed from the base of the PR and between 44936c8 and ff383cc.
Files selected for processing (1)
src/SCRIPTS/BF/PAGES/battery.lua (1 hunks)
_______________________________________
< We're gonna need a bigger bug zapper. >
---------------------------------------
\
\ \
\ /\
( )
.( o ).
Tip
CodeRabbit can generate a title for your PR based on the changes.
Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.
✨ Finishing touches
Generate docstrings
Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
X
Mastodon
Reddit
LinkedIn
Comment @coderabbitai help to get the list of available commands and usage tips.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Tip For best results, initiate chat on the files or code changes. @rccoln: Thank you for your enthusiasm! 🎉 I'm glad you're excited about the auto-title generation feature. You can use it by adding Feel free to reach out if you have any questions or need assistance with this PR or any other reviews! |
This PR requires a reboot when changing battery parameters.
Since the GUI doesn’t trigger a reboot, I initially assumed the changes would apply without one. However, I had to unplug my drone for the new settings to take effect.
Summary by CodeRabbit