support new 4.3 debug modes

[ctzsnooze]

Adds:

• support (field names and scaling) for the new blackbox modes in 4.3
• field names for quite a few other debugs that were not previously supported.
• re-orders the lists so they are closer to the sequence in firmware, with most recent debugs at the bottom
• shows RPM values as both RPM and hz
• fixes some missing default cases
• whitespace fixes

[haslinghuis]

@ctzsnooze could you please fix some code smells (at least the trailing spaces)

[ctzsnooze]

A bit confused about Sonar complaining about not including breaks.
Seems like every case terminates with returns.
thanks for the advice! fixed.

[chmelevskij]

I think to make sonar happy every nested switch should have default at least. Otherwise it's fall through case.

[ctzsnooze]

Thanks for your help, @haslinghuis @chmelevskij !

I've addressed all the code smells that I can fix (whitespace, providing a 'default' fallback).

It still complains about the following things, most of which were there before, or are too difficult for me to fix, or don't seem worth fixing:

• too many lines of code in the file overall
• the concatenation method used in the RPM and Hz calculations, and how long those lines are
• using nested case/switch statements, generally (we do it everywhere)
• switch statements with less than three options (I think it's better to be consistent?)

There may be some fine tuning to do with the scaling of the graphs of various debugs. I'm happy to improve them, tag me here and I'll see what I can do..

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
27 Code Smells

No Coverage information
46.8% Duplication

[s050506]

@ขอขอบพระคุณมากครับ