Show Dmax in log header properly for 4.3 #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctzsnooze
force-pushed
the
add-dmin-column
branch
from
d4142af to
136add3
Compare
chmelevskij
reviewed
Dec 27, 2021
ctzsnooze
force-pushed
the
add-dmin-column
branch
from
136add3 to
f792779
Compare
chmelevskij
previously approved these changes
Dec 27, 2021
haslinghuis
previously approved these changes
Dec 28, 2021
ctzsnooze
dismissed stale reviews from haslinghuis and chmelevskij
via
aff1bc2
ctzsnooze
force-pushed
the
add-dmin-column
branch
from
f792779 to
aff1bc2
Compare
Member
Author
|
Rebased over master. |
|
Kudos, SonarCloud Quality Gate passed!
|
haslinghuis
approved these changes
Dec 28, 2021
Member
haslinghuis
left a comment
haslinghuis
left a comment
There was a problem hiding this comment.
Not going to complain over spaces, var, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts a Dmax column in the PID display section of the log header to show values like in Configurator. Thanks to @asizon for assistance and advice.
Added case/break to fix and issue CSV values were not being parsed properly. If there is a neater way to do it, please let me know.
Now we don't need separate Dmin rows, we can rearrange the D parameters. This is how the PID box now looks: