Skip to content

Conversation

@McGiverGim
Copy link
Member

This moves the CI system from Azure pipelines to Github Actions, like it has been done in the Configurator.

Thanks to @mathiasvr for the original code, this only modifies it slightly.

@blckmn this will need the same changes done in the Configurator before merging:

  • Update the branch protection settings for pull requests to require the GitHub Action steps instead of the Azure Pipelines steps
  • Add environment secret named REPO_TOKEN with a token having (at least) public_repo privileges

This has been tested in the Configurator, so I think is safe to merge. I have tested it in my repo too before doing the PR.

haslinghuis
haslinghuis previously approved these changes Feb 16, 2022
asizon
asizon previously approved these changes Feb 17, 2022
@McGiverGim McGiverGim dismissed stale reviews from asizon and haslinghuis via 5ec84f0 February 17, 2022 14:06
@McGiverGim
Copy link
Member Author

Pushed a change to add an empty line to the end of files, and mark the nightly as prerelease.

haslinghuis
haslinghuis previously approved these changes Feb 17, 2022
asizon
asizon previously approved these changes Feb 17, 2022
@McGiverGim McGiverGim dismissed stale reviews from asizon and haslinghuis via 3ff4358 February 20, 2022 12:59
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.4% 11.4% Duplication

@McGiverGim
Copy link
Member Author

Removed the prerelease tag...

haslinghuis
haslinghuis previously approved these changes Feb 20, 2022
@haslinghuis haslinghuis requested a review from blckmn February 24, 2022 00:46
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@McGiverGim
Copy link
Member Author

Go out, stale bot...

@blckmn
Copy link
Member

blckmn commented Apr 15, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@McGiverGim McGiverGim requested a review from asizon May 4, 2022 13:22
KarateBrot
KarateBrot previously approved these changes May 18, 2022
asizon
asizon previously approved these changes May 18, 2022
blckmn
blckmn previously approved these changes May 18, 2022
@haslinghuis
Copy link
Member

haslinghuis commented May 18, 2022

Please don't merge yet. Need to solve sonar duplication warnings (otherwise we have this issue on each subsequent change).

@haslinghuis
Copy link
Member

haslinghuis commented May 18, 2022

@McGiverGim please rebase (if needed) and push again so we are able to analyze the build (as it's not available anymore)

@McGiverGim
Copy link
Member Author

McGiverGim commented May 18, 2022

I can do it tomorrow, but I see the build and the artifacts available.

@McGiverGim McGiverGim dismissed stale reviews from blckmn, asizon, KarateBrot, and haslinghuis via 728b108 May 19, 2022 07:25
@McGiverGim McGiverGim force-pushed the move_azure_actions branch from 3ff4358 to 728b108 Compare May 19, 2022 07:25
@McGiverGim
Copy link
Member Author

Rebased against master...

@McGiverGim McGiverGim force-pushed the move_azure_actions branch 2 times, most recently from d002a6e to e6a13c0 Compare May 19, 2022 07:46
@McGiverGim
Copy link
Member Author

I don't know why it detects the code duplication. My PR does not touch the files that complains. Maybe SonarCloud has modified the way to detect duplications and for this reason now it appears in this PR.

@haslinghuis
Copy link
Member

Problem is in

image

haslinghuis
haslinghuis previously approved these changes May 19, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.3% 11.3% Duplication

@McGiverGim
Copy link
Member Author

Rebased, the false positive of code duplication continues there...

@blckmn blckmn merged commit 192519a into betaflight:master May 20, 2022
@McGiverGim
Copy link
Member Author

@blckmn it seems some permission is missing for the nightly release. Did you add it as requested on the first message?

@blckmn
Copy link
Member

blckmn commented May 21, 2022

@blckmn it seems some permission is missing for the nightly release. Did you add it as requested on the first message?

Yep - missed that step. Have now added the repo_token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants